commit e81ccc502e54211ad9b2a5bd456fb6a73754a2b6 Author: Jacob Welsh AuthorDate: Sun Apr 21 03:33:27 2024 +0000 Commit: Jacob Welsh CommitDate: Sun Apr 21 03:34:35 2024 +0000 busybox/archival: fix earlier comment diff --git a/base/busybox/archival/libarchive/data_extract_all.c b/base/busybox/archival/libarchive/data_extract_all.c index 5e52911..a44bcc1 100644 --- a/base/busybox/archival/libarchive/data_extract_all.c +++ b/base/busybox/archival/libarchive/data_extract_all.c @@ -189,7 +189,7 @@ void FAST_FUNC data_extract_all(archive_handle_t *archive_handle) ) { bb_perror_msg("can't make dir %s", file_header->name); } - /* TODO maybe warn also if it exists and ISN'T a dir. Due to the initial path check, this doesn't by itself open a symlink attack, but it does mean we failed to reproduce the archive structure. Although this only arises if neither ARCHIVE_UNLINK_OLD nor ARCHIVE_O_TRUNC is set, which doesn't happen for tar, the use case of most interest. */ + /* TODO maybe warn also if it exists and ISN'T a dir. Due to the initial path check, this doesn't by itself open a symlink attack, but it does mean we failed to reproduce the archive structure. (This can happen when neither ARCHIVE_UNLINK_OLD nor ARCHIVE_O_TRUNC is set, for instance with tar -k.) */ break; case S_IFLNK: /* Symlink */