Comments on: A thorny memory leak in bitcoind, and a way forward http://jfxpt.com/2025/a-thorny-memory-leak-in-bitcoind-and-a-way-forward/ The search for invariants Tue, 14 Apr 2026 08:05:37 +0000 http://polimedia.us hourly 1 By: Jacob Welsh http://jfxpt.com/2025/a-thorny-memory-leak-in-bitcoind-and-a-way-forward/#comment-3344 Jacob Welsh Mon, 13 Oct 2025 03:19:25 +0000 http://jfxpt.com/?p=293#comment-3344 <a href="/codeview/tree/bitcoin/bitcoin_reorg_bounded_space/bitcoin/src/net.h#L217" rel="nofollow">CNode::setInventoryKnown</a> is a similar egregious free memory sinkhole, growing without bound even in normal operation though presumably at least freed on disconnect. It's also suspected of contributing to block download troubles, because <a href="/codeview/tree/bitcoin/bitcoin_reorg_bounded_space/bitcoin/src/main.cpp#L1995" rel="nofollow">this PushInventory</a> will fail to inform the peer of a required block when they "should" know about it because we happened to send it before, regardless of whether it was usable to them. (IIRC a Fixpoint commenter pointed this out some years ago, perhaps only in the abstract, but I'm not presently finding it in the relevant places.) CNode::setInventoryKnown is a similar egregious free memory sinkhole, growing without bound even in normal operation though presumably at least freed on disconnect. It's also suspected of contributing to block download troubles, because this PushInventory will fail to inform the peer of a required block when they "should" know about it because we happened to send it before, regardless of whether it was usable to them. (IIRC a Fixpoint commenter pointed this out some years ago, perhaps only in the abstract, but I'm not presently finding it in the relevant places.)

]]> By: Robinson Dorion http://jfxpt.com/2025/a-thorny-memory-leak-in-bitcoind-and-a-way-forward/#comment-3342 Robinson Dorion Sat, 11 Oct 2025 17:54:05 +0000 http://jfxpt.com/?p=293#comment-3342 <blockquote> The basic principles are 1) nothing may be expended without limit and 2) absent the possibility of weighing the value of things by their content, weigh by their source. </blockquote> Applying these principles will put us firmly on the path to differentiate it from the current <a href="http://jfxpt.com/2022/the-passive-threads-that-would-like-to-be-given-some-blocks/" rel="nofollow">passive</a>, <a href="http://trilema.com/2018/heres-how-pantsuitism-christianity-ruined-civilisation-in-both-the-ancient-and-the-modern-world/" rel="nofollow">pantsuitist</a>, <a href="http://trilema.com/2014/the-mobile-revolution-or-what-consumers-have-come-to-expect/" rel="nofollow">consumers</a> have come to expect <a href="http://trilema.com/2016/honor-societies-vs-respect-societies-or-how-the-disaster-of-commons-sunk-the-western-world/" rel="nofollow">respect</a> even if militantly naive because <a href="http://trilema.com/2020/forum-logs-for-07-apr-2017/#2265605" rel="nofollow">thinking</a> is hard to an <a href="http://trilema.com/2013/a-very-unfair-perspective/?b=There%20isn&e=the%20active.#select" rel="nofollow">active</a>, <a href="http://trilema.com/2018/patriarchy-vs-matriarchy-the-straight-dope/?b=history%20is%20made&e=being%20cool#select" rel="nofollow">patriarchal</a>, honor system that satisfies man's <a href="http://trilema.com/2021/the-needed/" rel="nofollow">need</a> to construct meritocratic hierarchies for effectual resource allocation. While rather thorny indeed, it's exciting to be unfolding this development. All the points in the 2nd list make sense to me. <blockquote> It's also noted that it may still be desirable to disconnect even good peers from time to time, to make room for mixing things up, better exploring the space and not being too predictable. </blockquote> <a href="http://trilema.com/2020/the-seven-laws/?b=Do%20not%20wallow&e=#select" rel="nofollow">Do not wallow content</a>. Word.

The basic principles are 1) nothing may be expended without limit and 2) absent the possibility of weighing the value of things by their content, weigh by their source.

Applying these principles will put us firmly on the path to differentiate it from the current passive, pantsuitist, consumers have come to expect respect even if militantly naive because thinking is hard to an active, patriarchal, honor system that satisfies man's need to construct meritocratic hierarchies for effectual resource allocation.

While rather thorny indeed, it's exciting to be unfolding this development.

All the points in the 2nd list make sense to me.

It's also noted that it may still be desirable to disconnect even good peers from time to time, to make room for mixing things up, better exploring the space and not being too predictable.

Do not wallow content. Word.

]]>