Comments on: Basic getrawtransaction patch proposal for bitcoind http://jfxpt.com/2019/basic-getrawtransaction-patch-proposal-for-bitcoind/ The search for invariants Sun, 19 Apr 2026 00:18:14 +0000 http://polimedia.us hourly 1 By: Sending buffer overflows fixed in bitcoind, and other cleanups « Fixpoint http://jfxpt.com/2019/basic-getrawtransaction-patch-proposal-for-bitcoind/#comment-2040 Sending buffer overflows fixed in bitcoind, and other cleanups « Fixpoint Sat, 21 May 2022 22:40:13 +0000 http://fixpoint.welshcomputing.com/?p=71#comment-2040 [...] [^]Some exceptions were a series presenting a new program while it was still somewhat in flux, my cautious first step into proposing changes to the big scary TRB, and an in-depth review of a desired patch from an unknown entity. [^]The joke is that in my [...] [...] [^]Some exceptions were a series presenting a new program while it was still somewhat in flux, my cautious first step into proposing changes to the big scary TRB, and an in-depth review of a desired patch from an unknown entity. [^]The joke is that in my [...]

]]> By: Mapping the bitcoind block acceptance code, with bonus patch for index access « Fixpoint http://jfxpt.com/2019/basic-getrawtransaction-patch-proposal-for-bitcoind/#comment-2011 Mapping the bitcoind block acceptance code, with bonus patch for index access « Fixpoint Tue, 22 Mar 2022 04:12:29 +0000 http://fixpoint.welshcomputing.com/?p=71#comment-2011 [...] enough, and the field naming and formatting follows existing precedent. To my mind this command is another one of those things that should have been there from the start; so barring any valid objections, I will consider it [...] [...] enough, and the field naming and formatting follows existing precedent. To my mind this command is another one of those things that should have been there from the start; so barring any valid objections, I will consider it [...]

]]> By: New and improved raw transaction support for bitcoind « Fixpoint http://jfxpt.com/2019/basic-getrawtransaction-patch-proposal-for-bitcoind/#comment-253 New and improved raw transaction support for bitcoind « Fixpoint Wed, 22 Apr 2020 05:25:31 +0000 http://fixpoint.welshcomputing.com/?p=71#comment-253 [...] on Fixpoint, I introduced my implementation of the getrawtransaction command and reviewed an existing one for sendrawtransaction. There were some more and less serious problems [...] [...] on Fixpoint, I introduced my implementation of the getrawtransaction command and reviewed an existing one for sendrawtransaction. There were some more and less serious problems [...]

]]> By: Preliminary report on the bitcoind hex conversion mess « Fixpoint http://jfxpt.com/2019/basic-getrawtransaction-patch-proposal-for-bitcoind/#comment-241 Preliminary report on the bitcoind hex conversion mess « Fixpoint Sat, 11 Apr 2020 16:46:41 +0000 http://fixpoint.welshcomputing.com/?p=71#comment-241 [...] I previously noted about my getrawtransaction patch, It does accept invalid hex strings, perhaps a flaw in that SetHex [...] [...] I previously noted about my getrawtransaction patch, It does accept invalid hex strings, perhaps a flaw in that SetHex [...]

]]> By: Mircea Popescu http://jfxpt.com/2019/basic-getrawtransaction-patch-proposal-for-bitcoind/#comment-136 Mircea Popescu Thu, 19 Dec 2019 06:00:46 +0000 http://fixpoint.welshcomputing.com/?p=71#comment-136 Aha. Aha.

]]> By: Jacob Welsh http://jfxpt.com/2019/basic-getrawtransaction-patch-proposal-for-bitcoind/#comment-126 Jacob Welsh Sun, 15 Dec 2019 20:20:56 +0000 http://fixpoint.welshcomputing.com/?p=71#comment-126 "This needs a looking into tho." - for sure & will do. I may be missing some <a href="http://jfxpt.com/2019/review-of-polarbeard_add_sendrawtransaction_rpcvpatch/?b=CRITICAL&e=)#select" rel="nofollow">locking</a> around the mapTransactions access. There appears to be a <a href="http://btc.yt/lxr/satoshi/source/src/bitcoinrpc.cpp?v=makefiles#2279" rel="nofollow">coarse-grained lock on cs_main</a> for all the RPCs, which probably explains why they're so damn laggy. "This needs a looking into tho." - for sure & will do.

I may be missing some locking around the mapTransactions access. There appears to be a coarse-grained lock on cs_main for all the RPCs, which probably explains why they're so damn laggy.

]]> By: Mircea Popescu http://jfxpt.com/2019/basic-getrawtransaction-patch-proposal-for-bitcoind/#comment-91 Mircea Popescu Thu, 05 Dec 2019 17:52:40 +0000 http://fixpoint.welshcomputing.com/?p=71#comment-91 > better suited to an external tool Logically the node should really be two parts, a curl part and an awk part so to speak. There's really no reason for the awk part to be always-on, nor for the always-on part to contain a whole, turing-complete, domain language baked in. Blindness to this glaringly obvious split is what drove power ranger idiocy in the "verbose" json vein and so on. Simple droplets. > couldn't just be one global (or at least per-thread) "This Is The Database; Use It" See ? > It does accept invalid hex strings, perhaps a flaw in that SetHex method. This needs a looking into tho. > better suited to an external tool

Logically the node should really be two parts, a curl part and an awk part so to speak. There's really no reason for the awk part to be always-on, nor for the always-on part to contain a whole, turing-complete, domain language baked in. Blindness to this glaringly obvious split is what drove power ranger idiocy in the "verbose" json vein and so on. Simple droplets.

> couldn't just be one global (or at least per-thread) "This Is The Database; Use It"

See ?

> It does accept invalid hex strings, perhaps a flaw in that SetHex method.

This needs a looking into tho.

]]>